Affirm's strong Q2 results show market leadership, but risks include competition, credit quality, and valuation concerns.